Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GCP] Add various dashboards #5025

Merged
merged 10 commits into from
Feb 24, 2023
Merged

[GCP] Add various dashboards #5025

merged 10 commits into from
Feb 24, 2023

Conversation

endorama
Copy link
Member

@endorama endorama commented Jan 17, 2023 •
edited
Loading

What does this PR do?

Some dashboards have not been migrated during the migration from gcp beat module to the integration package.

This PR adds the missing ones, updating them to the latest dashboard development guidelines.

Updates:

  • GKE overview dashboard
  • PubSub metrics overview dashboard
  • Audit events overview dashboard
  • Storage metrics overview dashboard

GCP package is bumped to 2.17.0.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

  • Start Elastic cluster with elastic-package stack up --version 8.6.1
  • Collect data for GKE, PubSub and Storage metrics by adding a policy with appropriate credentials
  • Collect data for Audit Logs; default policy information should be enough, as the required collection infrastructure is already in place
  • verify dashboard show data and filters work as expected

Related issues

Screenshots

GCP Audit logs

Screenshot 2023-02-13 at 17-59-59 Elastic

GCP GKE

Screenshot 2023-02-13 at 18-04-30 Elastic

GCP Storage

Screenshot 2023-02-13 at 18-04-35 Dashboards - Elastic

GCP PubSub

Screenshot 2023-02-13 at 18-04-39 Elastic

@endorama endorama requested review from a team as code owners January 17, 2023 17:18
@endorama
Copy link
Member Author

Moving this back to draft as I exported some dashboard using the next development version.

@endorama endorama marked this pull request as draft January 17, 2023 17:20
@elasticmachine
Copy link

elasticmachine commented Jan 17, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-24T14:20:07.043+0000

  • Duration: 19 min 56 sec

Test stats 🧪

Test Results
Failed 0
Passed 57
Skipped 0
Total 57

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@andrewkroh andrewkroh added the Integration:gcp Google Cloud Platform label Jan 18, 2023
@andrewkroh andrewkroh changed the title Add various GCP dashboard [GCP] Add various dashboards Jan 18, 2023
@andrewkroh
Copy link
Member

Please attach some screenshots when these are ready.

@endorama
Copy link
Member Author

@andrewkroh I tried to update visualisations in the Audit dashboard to use Lens, but I've not been able to reproduce the same dashboard.

Before:
gcp audit before

After:
gcp audit after

In particular "Audit Events Outcome over time" panel does not show "unknown" documents (not sure why, I selected the "display docs without value"). Is this a blocker?

@andrewkroh
Copy link
Member

andrewkroh commented Jan 23, 2023 •
edited
Loading

I think this is fine. It used to show [unknown] when the field was missing. And now it's just showing "(missing value)". So I think that is fine.

Old settings (non-Lens):

Screen Shot 2023-01-23 at 14 41 34

@endorama
Copy link
Member Author

@andrewkroh I've been able to reproduce the behaviour.

Also I updated the description with screenshots and updated the PR remove coflicts. Moveing to Ready for review

@endorama endorama marked this pull request as ready for review February 13, 2023 17:11
@elasticmachine
Copy link

elasticmachine commented Feb 13, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (6/6) 💚
Files 100.0% (6/6) 💚 13.636
Classes 100.0% (6/6) 💚 13.636
Methods 90.291% (93/103) 👍 6.702
Lines 96.0% (1464/1525) 👍 11.07
Conditionals 100.0% (0/0) 💚

dmathieu
dmathieu approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been able to review all dashboards, except the audit log one (we don't know why yet, but I'm not getting data).
That dashboard has already been approved by security though. So stamping this PR.

@endorama endorama merged commit bf85fb5 into elastic:main Feb 24, 2023
@endorama endorama deleted the gcp-metrics-dashboards branch February 24, 2023 15:48
@endorama endorama mentioned this pull request Feb 24, 2023
Open
@elasticmachine
Copy link

Package gcp - 2.17.0 containing this change is available at https://epr.elastic.co/search?package=gcp

1 similar comment
@elasticmachine
Copy link

Package gcp - 2.17.0 containing this change is available at https://epr.elastic.co/search?package=gcp

@elasticmachine
Copy link

Package gcp - 2.17.0 containing this change is available at https://epr.elastic.co/search?package=gcp

1 similar comment
@elasticmachine
Copy link

Package gcp - 2.17.0 containing this change is available at https://epr.elastic.co/search?package=gcp

agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 20, 2023
@endorama @agithomas
[GCP] Add various dashboards (elastic#5025)
acd767f
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
@endorama @agithomas
[GCP] Add various dashboards (elastic#5025)
58e6926
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@dmathieu dmathieu dmathieu approved these changes

Assignees
No one assigned
Labels
Integration:gcp Google Cloud Platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@endorama @elasticmachine @andrewkroh @dmathieu